trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Modus NavBar - Allow for user icon border color configuration #1270

Open cjwinsor opened 1 year ago

cjwinsor commented 1 year ago

Prerequisites

Proposal

Allow for the user icon to have its border and initial background color to be configurable.

Presently, the avatar image / initials span are given borders when active, focused, and hovered. This proposal is to allow for a border color to exist when not interacted with. Presently, we cannot control whether the border is showing, nor what color it is. The implementation details are TBD.

image

It is e-Builder's intent to work on this request.

Motivation and context

As part of e-Builder's user delegation feature, we are looking to indicate when the user is acting on behalf of another user by adding a border around their avatar/initials.

Which npm package?

@trimble-oss/modus-web-components

Priority

Medium

What is the product name the feature is requested for?

e-Builder

What is the team name the product belongs to?

e-Builder

What is the division name the team belongs to?

e-Builder

msankaran0712 commented 1 year ago

@cjwinsor should we assign this to someone in your team?

msankaran0712 commented 1 year ago

@msankaran0712 check with @cjwinsor

msankaran0712 commented 1 year ago

@cjwinsor, do you want to assign this to someone? and we can choose the sprint too

cjwinsor commented 1 year ago

@msankaran0712 Currently working through where this is with UX approvals and Modus approvals. We have no issue picking this up after we validate that, however we are about to work on microservices to provide the data we need for implementing the navbar so it will be after that.

Do we know if we want to have this as a core feature, setting the ring color and background color as properties of the profileMenuOptions? Something like this, but not necessarily this:

{
  //...
  highlightBorderColor: '',
  highlightBackgroundColor: ''
  //...
}
msankaran0712 commented 1 year ago

@cjwinsor I was thinking of keeping it simple by creating CSS variables, that way, you can control it based on the theme selected.

msankaran0712 commented 1 year ago

This is to reaffirm that Modus has approved the functionality for development.

cc @cjwinsor

Note: Modus team tag the approved issues with modus-approved

msankaran0712 commented 11 months ago

Moved this to backlog as the issue has been idle for quite sometime

msankaran0712 commented 10 months ago

@cjwinsor any updates on when are we taking this issue?