search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 71 forks source link

Setup Nx for building and publishing of our multiple projects #1353

Open coliff opened 1 year ago

coliff commented 1 year ago

We should setup Nx to manage the building and publishing of our multiple projects (Modus Web Components, Modus React Components and Modus Angular Components).

REF: https://nx.dev/getting-started/intro

When we publish a new version of Modus Web Components we also want the system to publish:

leohaughton commented 1 year ago

Hey @coliff Just looking at this issue. I didn't see it before I started the react 18 integration work that I am doing.

I have just followed the existing pattern of using create-react-app projects for the React 18 integration. Is this ok? My changes won't include the ability to auto publish when we publish an updated modus library.

Should I submit my PR against this issue or create another one?

msankaran0712 commented 1 year ago

Hey @coliff Just looking at this issue. I didn't see it before I started the react 18 integration work that I am doing.

I have just followed the existing pattern of using create-react-app projects for the React 18 integration. Is this ok? My changes won't include the ability to auto publish when we publish an updated modus library.

Should I submit my PR against this issue or create another one?

I think the PR for creating separate folders for each react version is good enough for now 👍🏼