trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
31 stars 65 forks source link

Date Picker - Available dates should dynamically update to reflect the latest changes without requiring a manual refresh. #2095

Closed yshnaviganapathi closed 5 months ago

yshnaviganapathi commented 5 months ago

Prerequisites

Describe the issue

Bug Description: The Date Picker component in the Modus Web Components library presents an issue when modifying the minimum and maximum dates using the UI controls. Specifically, when selecting a date that falls below the minimum date or exceeds the maximum date, navigating to available dates in the calendar does not update to reflect the latest changes. A manual refresh of the URL is required to observe the correct behavior.

Reduced test cases

Expected Behavior: After modifying the minimum and maximum dates and selecting a date outside the valid range, navigating to available dates should dynamically update to reflect the latest changes without requiring a manual refresh.

Technical Scenario:

Test Data:

Test URL Existing Minimum Date: 2022-12-02 Existing Maximum Date: 2022-12-30 Current Date Value: 2022-12-22 Updated Maximum Date: 2023-01-31 Updated Current Date Value: 2023-12-22

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

Modus

What is your team/division name ?

Modus

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 5 months ago

Hello @yshnaviganapathi! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

ElishaSamPeterPrabhu commented 5 months ago

The date picker maintains state for maximum and minimum dates which are loaded along with the component , they are not required to be handled dynamically hence the behavior not considered an issue.