search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
31 stars 66 forks source link

Slider Emits String Instead of Number #2198

Open kuhnboy opened 5 months ago

kuhnboy commented 5 months ago

Prerequisites

Describe the issue

A modus slider (even though the value, max, and min are all numeric) emits a string on the valueChange event.

Example:

<body>
    <modus-slider label="Slider"></modus-slider>

    <script>
    const modusSlider = document.querySelector('modus-slider');
    modusSlider.addEventListener('valueChange', (evt) => {
        alert(typeof evt.detail);
    });
    </script>
</body>

I would expect the event detail to be a number.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.16.0

Priority

Medium

What product/project are you using Modus Components for ?

ModusBlazor

What is your team/division name ?

AECO

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 5 months ago

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.