search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Modus Table with rowSelectrion=true issue with state immutability #2306

Open Andrei-Ghe opened 7 months ago

Andrei-Ghe commented 7 months ago

Prerequisites

Describe the issue

The issue occurs when using NGRX to populate a modus-table with selection mode on. Checking a box in the table shows "Cannot assign to read only property 'id' of object '[object Object]' " in the console. The state is immutable by default in the app and disabling it can solve the problem but it would not be a long term solution.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-angular-components

What version of npm package are you using ?

^0.20.0-ng16

Priority

Medium

What product/project are you using Modus Components for ?

ViewPoint

What is your team/division name ?

White Team

Are you willing to contribute ?

No

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 7 months ago

Hello @Andrei-Ghe! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.