trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Modus Action Bar - Export `ModusActionBarOptions` interface #2511

Open Kai-Richardson opened 6 months ago

Kai-Richardson commented 6 months ago

Prerequisites

Describe the issue

Right now, ModusActionBarOptions is not exported so we have to have a duplicate of the interface type.

https://github.com/trimble-oss/modus-web-components/blob/fb00a5f5b6117809e848c54ddae3e6eb32779a3e/stencil-workspace/src/components/modus-action-bar/modus-action-bar.tsx#L13

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.27.0-react18

Priority

Medium

What product/project are you using Modus Components for ?

Viewpoint Cascade

What is your team/division name ?

Cascade

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 6 months ago

Hello @Kai-Richardson! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

Kai-Richardson commented 6 months ago

Ah, I think what I'm seeing here is a strange duplicate export: export { ModusActionBarOptions } from "./components/modus-action-bar/modus-action-bar"; export { ModusActionBarOptions as ModusActionBarOptions1 } from "./components/modus-action-bar/modus-action-bar";