Content tree: Keyboard navigation to move items

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).

https://modus-web-components.trimble.com/

MIT License

30 stars 63 forks source link

Content tree: Keyboard navigation to move items #2523

Open ElishaSamPeterPrabhu opened 2 weeks ago

ElishaSamPeterPrabhu commented 2 weeks ago

Description

Added Keyboard navigation to move items from one position to another

References Fixes #1597

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

netlify[bot] commented 2 weeks ago

Deploy Preview for moduswebcomponents ready!

Name	Link
Latest commit	2c4063ed5d0962efeb686f4ed0bd52ac790aeb5f
Latest deploy log	https://app.netlify.com/sites/moduswebcomponents/deploys/6659b4565505070008a112c1
Deploy Preview	https://deploy-preview-2523--moduswebcomponents.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 22 (🔴 down 1 from production) Accessibility: 98 (no change from production) Best Practices: 92 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cjwinsor commented 2 weeks ago

@ElishaSamPeterPrabhu 2 things: When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

ElishaSamPeterPrabhu commented 1 week ago

@ElishaSamPeterPrabhu 2 things: When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

Updated the up and down behavior as expected and added escape to cancel draggable state