trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

button.setActive in the ModusButtonGroup is not a function #2591

Open pgomez674 opened 5 months ago

pgomez674 commented 5 months ago

Prerequisites

Describe the issue

Hi modus team.

For the modus library on the version "@trimble-oss/modus-react-components": "^0.29.0-react18" we found a issu on the ModusButtonGroup, that is not able to switch the button once some of them are clicked. The log error is the following:

image

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.29.0-react18

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Inspections: https://confluence.trimble.tools/pages/viewpage.action?spaceKey=PNETTECH&title=Trimble+Inspections

What is your team/division name ?

guara/transportation

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

https://fleetmanager.trimble.com/#/inspections/

github-actions[bot] commented 5 months ago

Hello @pgomez674! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

cjwinsor commented 5 months ago

@pgomez674 Can you provide a code sample to show the use here. We have an undocumented setActive function that we use internally. We'd like to understand how you are using the control before proceeding.

pgomez674 commented 4 months ago

This is our current implementation: image

if you want to check our code implementation, this is our repository

We folllow the documentation on the modus web components page

pgomez674 commented 4 months ago

If you need permissions to see the repository you can ping me on a DM

leosole-trimble commented 4 months ago

The ButtonGroup component is also loading the buttons differently from the storybook. I believe the buttons should have a straight border, not rounded. image