search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 71 forks source link

Modus Modal: Close button displays top left if headerText is not provided #2598

Open raymondboswel opened 4 months ago

raymondboswel commented 4 months ago

Prerequisites

Describe the issue

The title pretty much sums it up. Since headerText is optional, I wouldn't expect the close 'x' to behave differently, and it is a bit jarring.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

^0.28.0-react18

Priority

Low

What product/project are you using Modus Components for ?

WorksOS / Machine Playback

What is your team/division name ?

CCFS/Weka

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 4 months ago

Hello @raymondboswel! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.