trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
31 stars 65 forks source link

Modus Side Nav: option to replace click handlers with anchor tags and URLs #2651

Open gabriel-piltzer-trimble opened 1 week ago

gabriel-piltzer-trimble commented 1 week ago

Prerequisites

Proposal

Users want to be able to middle mouse click or right click and open in new tab from the navigation. For this to work we need anchor tags with URLs in nav <li>. I propose an optional way to swap the provided click handlers with anchor tags.

Motivation and context

Make the modus side nav more user friendly for opening links.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Prism

What is your team/division name ?

Viewpoint

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

Not yet

github-actions[bot] commented 1 week ago

Hello @gabriel-piltzer-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.