search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 71 forks source link

Actions vs Property Changes #2674

Open kuhnboy opened 3 months ago

kuhnboy commented 3 months ago

Prerequisites

Proposal

In most components such as the Navbar, instead of setting properties after render such as showMainMenu there is an action method such as hideMainMenu.

In the Utility Panel, the example suggests using an expanded property and setting it after rendering to control the expanded / collapsed state. Shouldn't this be a method to encapsulate post-render functionality?

Not sure what's the best here but I'm seeing an inconsistency.

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components, Modus Web Components Website (Storybook)

Priority

Low

What product/project are you using Modus Components for ?

Trimble Unity

What is your team/division name ?

O&PS

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 3 months ago

Hello @kuhnboy! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.