search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Modus Table - Bugs #2701

Open venkyn13 opened 4 months ago

venkyn13 commented 4 months ago

Prerequisites

Describe the issue

  1. Rowoptions column width needs to be small and fixed, right now it is 90 px
  2. Dropdown menu has alignment issue, like dropdown menu options is not fully visible on bottom row
  3. Rowselection column width needs to be small and fixed (this issue is similar to issue 1)
  4. Right now, available table displayOptions are borderless and cellborderless, but we need the border only after each row(like in modus react Datatable).

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

Field data

What is your team/division name ?

Geospatial - CPD

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 4 months ago

Hello @venkyn13! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

prashanth-offcl commented 2 months ago

@venkyn13 The issues mentioned will be addressed in a separate issues and I've linked it. Please check and tell if that address all your concerns.

  1. Rowoptions column width needs to be small and fixed, right now it is 90 px - Will be addressed in #1922
  2. Dropdown menu has alignment issue, like dropdown menu options is not fully visible on bottom row - Will be addressed in #2783
  3. Rowselection column width needs to be small and fixed (this issue is similar to issue 1) - Will be addressed in #1922
  4. Right now, available table displayOptions are borderless and cellborderless, but we need the border only after each row(like in modus react Datatable) - Fixed in #2675
venkyn13 commented 2 months ago

@prashanth-offcl, I have checked the above mentioned issues and on 2nd issue, in addition to 'dropdown is hidden behind grid container', please double check that the 'actual dropdown menu options alignment is correct' - like when i click dropdown menu the options should be aligned based on available space(if there is enough space on right, it should be at right, else at left and the same for top and bottom)

Apart from this, everything is ok for me