search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Table: Context Menu-Only Row Actions #2789

Open rhenness opened 3 months ago

rhenness commented 3 months ago

Prerequisites

Proposal

The current table component displays a number of row actions inline within a designated column. Once the inline space is exhausted, additional actions are placed within a context menu dropdown. This feature request proposes the ability to move all row actions to the context menu dropdown, removing them from the inline display entirely.

Requirements:

  1. Context Menu-Only Actions:

    • Provide an option to configure the table so that all row actions are placed within the context menu dropdown, with none displayed inline.

  2. Icons in Context Menu:

    • Ensure that icons can be displayed next to individual row actions within the context menu.
    • Allow customization of icon colors within the context menu to give the consumer more control.

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Viewpoint applications

What is your team/division name ?

Trimble Viewpoint

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 3 months ago

Hello @ryan-henness-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

rhenness commented 3 months ago

@enowak1031 We may want to escalate this one as it's behaving differently than the majority of design doc requirements. Can this be bumped closer to the front of the review queue? I am willing to implement the feature

prashanth-offcl commented 3 months ago

@enowak1031 We may want to escalate this one as it's behaving differently than the majority of design doc requirements. Can this be bumped closer to the front of the review queue? I am willing to implement the feature

@ryan-henness-trimble Your proposal has been reviewed and accepted by the design team. We would gladly accept your contributions.

PS: Icons in context menu - The modus-list component is used in the dropdown and currently accepts left icon as prop, if your requirement is to show icons on the right side which is one of the variants as per Figma, then we need to change the selected state as well.