trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

List: Inconsistency in right Icon guidelines for Modus List Item #2797

Open prashanth-offcl opened 2 months ago

prashanth-offcl commented 2 months ago

Prerequisites

Describe the issue

The current style guide specifies using a tick icon to represent the active state for the ModusListItem right icon. However, this does not match the design presented in the Figma mocks.

PS: The component implemented the right icon as per the style guide, and there is no option to display a different icon, as it is reserved for the tick icon.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

Low

What product/project are you using Modus Components for ?

modus-internal

What is your team/division name ?

modus-internal

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 2 months ago

Hello @prashanth-offcl! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

prashanth-offcl commented 2 months ago

@mitch-trimble Need your recommendation to proceed on this issue.