trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
33 stars 70 forks source link

Table: Row Selection column sizing regression in 0.36 #2807

Open Kai-Richardson opened 2 weeks ago

Kai-Richardson commented 2 weeks ago

Prerequisites

Describe the issue

image

A regression was introduced impacting the sizing of the rowSelection column for ModusTable. It now seems to act a fluid box or something strange, though I don't see anything in css. It might be the internal width calculation.

I can reproduce this in our project by simply changing the installed version of modus.

You can work around it by manually setting the width of the other columns, though this is pretty terrible.

2014 might be relevant/fix. Unsure though.

Reduced test cases

This is present in the storybook, seemingly? It's rendering super strangely. https://modus-web-components.trimble.com/?path=/story/components-table--checkbox-row-selection

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.36.0-react18

Priority

High

What product/project are you using Modus Components for ?

Viewpoint Cascade

What is your team/division name ?

Cascade

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

Imminently

github-actions[bot] commented 2 weeks ago

Hello @Kai-Richardson! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

prashanth-offcl commented 2 weeks ago

Related to #1922