search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 70 forks source link

Add a configuration on the modus-modal component to hide the full screen button #2867

Closed DancuVladTrimble closed 1 month ago

DancuVladTrimble commented 1 month ago

Prerequisites

Proposal

The purpose of this ticket is to add an *ngIf condition so that the full screen button can be shown/hidden based on the mode-modal configuration.

image image

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components, @trimble-oss/modus-angular-components

Priority

High

What product/project are you using Modus Components for ?

Trade Service Live

What is your team/division name ?

Con-Artist

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 1 month ago

Hello @DancuVladTrimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.