trimble-oss / modus

Welcome to the home of the Modus design system developer projects!
https://github.com/trimble-oss/modus
MIT License
10 stars 2 forks source link

Finalize All Icons for Publication - roundings #298

Closed enowak1031 closed 1 year ago

coliff commented 2 years ago

Feedback based on: https://modus-icons-test.netlify.app/

General

Naming / bugs

soniakaukonen commented 2 years ago

Feedback from .ai viewing

Pixel issues:

Modus-Account and Support-1021 and Modus-Account and Support-solid-1021 -web - close the small artifact in the lower part middle of the globe to simplify code

Not on-grid:

Modus-Actions and Navigation-1021 and Modus-Actions and Navigation-solid-1021 pause - line stroke is 3 px but could it be on grid to avoid pixelizing? rotate, drag-horizontal and drag-vertical - make arrow heads' bottom on-grid to avoid blur pan (in solid) - arrows should have the bottom on grid collapse (in solid) - arrow heads could be on grid

Roundings:

play - is the rounding of the arrow 2 px? Looks smaller

Doubles:

Do we really maintain the basic magnifier and remove/cancel, refresh/update under so many different names? Also bin? Should not it be done over keywords tags? Modus-Computer Hardware and Assets-1021 and Modus-Computer Hardware and Assets-solid-1021 Some devices repeat within this file and with others (envelope), should it rather be tagged? Paper sheet under different names - rather keywords instead of doubles Modus-Folders and Files-1021 and Modus-Folders and Files-solid-1021 Many doubles, rather keywords?

Weighting:

navigate -is there a reason that the circle is larger then other tokens? Only 1 px padding monitor - should rather the lower part be filled not the screen itself (consistent with tablets and mobiles)?

Modus-Documents and Reports-1021 and Modus-Documents and Reports-solid-1021

Fonts:

Fonts not converted to shapes! text - still looks very massive and not natural. Should it be simply converted from a font?'

Metaphor

As said earlier, drawings often don't look like a vertical A4, but horizontal with an index in the lower corner. Many products really need this distinction Modus-Messages-1021 Error and warning the same? I think they should have distinction. Warning triangle with ! Warning happens before something critical happens, error thereafter.

TBC...

soniakaukonen commented 2 years ago

part 2

Modus-Modelling-1021 and Modus-Modelling-solid-1021 Sphere is larger than 2px padding

General "Light" set:

Modus-Presentations and View-1021 and Modus-Presentations and View-solid-1021 Chevron unified for outline and solid according to discussion

Skip is a double from another file, should it rather be added to keywords instead of a double?

Errors:

walk-through - some unnecessary nodes on the tip of the left shoe / cut in a strange way moon-phase and darkmode are a double. Also in the Status file another moon for other. Keywords instead.

Modus-Save-and-Share-1021 and Modus-Save-and-Share-solid-1021 Same add-on e.g. the arrow down or up has diffeent padding e.g. with the cloud, floppy or in the Folder ai with the folder. Make it consistent.

Modus-Status-1021 and Modus-Status-solid-1021 Cloud could be on grid on the even bottom side

soniakaukonen commented 2 years ago

based on 24 px platform floppy disc was still better in tiger team proposal add on solid token should have consistent padding Dashboard solid becomes too detailed Desktop monitor should have a solid panel rather than the screen (consistency with mobile and tablet) Measure could have less intermediate lines T text is too massive both in solid and outlined