trimble-oss / modus

Welcome to the home of the Modus design system developer projects!
https://github.com/trimble-oss/modus
MIT License
10 stars 2 forks source link

Harmonize color code discrepancies in XD #374

Closed soniakaukonen closed 1 year ago

soniakaukonen commented 1 year ago

Findings to explore based on # 53

Inconsistencies XD:

soniakaukonen commented 1 year ago

Button findings:

Image

egunther39 commented 1 year ago

@soniakaukonen

Buttons, auxiliary icon only button sets:

Breadcrumbs: inconsistencies between Trimble Blue and Light blue across XD. Which one is correct (Figma legacy is Trimble blue) - Blue Light is Correct

Calendar picker in light got Trimble blue and in dark dark blue. Should not it be harmonized and follow the logic of Navbar, both dark blue? Otherwise it could be Dark Mode blue but the surface appears slightly too dominating. I don't think it's necessary to mimic the NavBar color as this is a completely different component. That said, we can change Dark mode to the below as it reads better against various backgrounds Light = Trimble Blue Dark = Let's use Trimble Blue Dark - #004F83

Checkboxes: Focused glow color code appears strange. Indeterminate light mode with label is inactive, without active. Intentional? Dark Mode default faulty in XD (iw/o label is deactivated instead) FIXED

Chips: deviations in dark mode hover and disabled among versions - XD IS CORRECT. Deviations are because one set is an OUTLINED chip, thus the border has to be the electric blue w/ a different BG fill. The other set is solid, and the only accessible background option is electric blue. The background color used in the outlined options doesn't work without the border

Messages: both colors of messages are called Primary in XD (Primary and Secondary in Figma) FIXED IN XD

Pagination light blue numbers (Trimble blue in legacy Figma) which is correct? XD IS CORRECT. THIS IS ANOTHER EXAMPLE OF A TOGGLE STATE SIMILAR TO CHECKBOXES

egunther39 commented 1 year ago

These are fixed in XD