Chevron padding for Pagination on Figma

trimble-oss / modus

Welcome to the home of the Modus design system developer projects!

https://github.com/trimble-oss/modus

MIT License

10 stars 2 forks source link

Chevron padding for Pagination on Figma #492

Closed jmecosta closed 9 months ago

jmecosta commented 1 year ago

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal

Motivation and context

usability

msankaran0712 commented 1 year ago

@soniakaukonen to confirm if the icon is correct in Modus Styleguide, Modus Bootstrap and Modus React Bootstrap

soniakaukonen commented 11 months ago

I checked the behavior of Pagination and Breadcrumbs along with the right/left chevron @msankaran0712

Pagination:

With 24 px icon, the actual symbol is only 6 10 px meaning fairly small with 9 7 px padding Breadcrumbs:
When 16 px icon is used, the actual symbol is anymore 4.5 7,5 px (padding 6 4 px)

This explains the poor visibility.

We have a fat chevron for in-field purposes but this is overwhelming the above mentioned components. The stroke is not as important as using most of the canvas.

Solution could be an additional chevron using more of the canvas within the 24 24 and 16 16 px.

msankaran0712 commented 11 months ago

Maha to confirm if there is any extra padding that can be removed

msankaran0712 commented 11 months ago

will wait for @soniakaukonen to update the figma

msankaran0712 commented 10 months ago

@jmecosta This will be fixed only on Styleguide, Figma and Modus Bootstrap. I have repurposed this issue to reflect the Figma changes, hope that's okay.

jmecosta commented 10 months ago

Also in modus web components? That's what we will begin using as per recommendation

msankaran0712 commented 10 months ago

@jmecosta Yes, currently Modus Web Components has its own icons and they are large enough. However, soon Modus Web Components will start using Modus Icons, which can be found at https://modus-icons.trimble.com/.

jmecosta commented 10 months ago

Ok clear. Thanks for the update.

On Mon, Aug 28, 2023, 08:19 Mahalakshmi Sankaran @.***> wrote:

@jmecosta https://github.com/jmecosta Yes, currently Modus Web Components has its own icons and they are large enough. However, soon Modus Web Components will start using Modus Icons, which can be found at https://modus-icons.trimble.com/.

— Reply to this email directly, view it on GitHub https://github.com/trimble-oss/modus/issues/492#issuecomment-1695025835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSHA6DYFKHZYEDBSJMLXXQS5BANCNFSM6AAAAAA36TIYBM . You are receiving this because you were mentioned.Message ID: @.***>