search

trimox / angular-mdc-web

Angular wrapper for Material Design (Web) Components
https://trimox.github.io/angular-mdc-web
MIT License
517 stars 87 forks source link

feat: Use Bazel for builds #2152

Closed trimox closed 4 years ago

trimox commented 4 years ago

BREAKING CHANGES: Components can no longer be imported through @angular-mdc/web. Use the individual secondary entry-points, such as @angular-mdc/web/button

Also, we no longer have a direct depedency on tslib. Instead it is now listed a peerDependency.

Users not using the Angular CLI will need to manually install tslib via;

yarn add tslib
# or
npm install tslib --save

closes #2151 closes #2153

trimox commented 4 years ago

Almost set. Snackbar and Dialog presenting difficulties..

trimox commented 4 years ago

Encountered numerous issues.

https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ

trimox commented 4 years ago

Finally complete! Will fix failing tests and merge.

codecov[bot] commented 4 years ago

Codecov Report

Merging #2152 into master will increase coverage by 0.12%. The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
+ Coverage   90.64%   90.76%   +0.12%     
==========================================
  Files         100       98       -2     
  Lines        4338     4332       -6     
  Branches      559      557       -2     
==========================================
  Hits         3932     3932              
+ Misses        214      210       -4     
+ Partials      192      190       -2
Impacted Files Coverage Δ
packages/button/button.ts 100.00% <ø> (ø)
packages/card/card.ts 98.30% <ø> (ø)
packages/checkbox/checkbox.ts 98.01% <ø> (ø)
packages/chips/chip-set.ts 87.12% <ø> (ø)
packages/chips/chip.ts 85.53% <ø> (ø)
packages/data-table/data-table.directives.ts 100.00% <ø> (ø)
packages/dialog/dialog-portal.ts 86.11% <ø> (+10.50%) :arrow_up:
packages/dialog/dialog-ref.ts 96.77% <ø> (ø)
packages/dialog/dialog.component.ts 88.00% <ø> (ø)
packages/dialog/dialog.ts 94.93% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63979c8...422b360. Read the comment docs.