search

trimox / angular-mdc-web

Angular wrapper for Material Design (Web) Components
https://trimox.github.io/angular-mdc-web
MIT License
518 stars 87 forks source link

Investigate StackBlitz issue compiling Sass #2212

Open trimox opened 4 years ago

trimox commented 4 years ago

Appears StackBlitz template(s) are not recognizing @use as valid Sass rule. Maybe time to look @ alternatives..

StackBlitz template (using canary): https://stackblitz.com/edit/angular-mdc

RikEskes commented 4 years ago

Could this perhaps be related to #2189 ?

trimox commented 4 years ago

@RikEskes Yep, both are related issue. Does your StackBlitz ever finish compiling and starting dev server?

image

RikEskes commented 4 years ago

The StackBlitz used to finish compiling. If it continues not to do so I will create a new one to ensure the issue is reproducible.

trimox commented 4 years ago

Wondering if enabling Ivy on StackBlitz is causing infinite compilation. Same thing occurs with https://stackblitz.com/edit/angular-mdc

trimox commented 4 years ago

Hrmm. Not sure this is an @use issue since import fails as well. Maybe something with the approach used inside angular.json's stylePreprocessorOptions to help Sass compiler locate the MDC Web Sass files?

"stylePreprocessorOptions": {
              "includePaths": [
                "node_modules/"
              ]
            },
RikEskes commented 4 years ago

I created a new StackBlitz project which does finish compiling: https://stackblitz.com/edit/angular-mdc-agnnan

guillaumegarcia13 commented 4 years ago

I noticed that in your example, @RikEskes, you have commented out the following:

// // Angular MDC
// @use '@angular-mdc/theme/material';

Any reason for doing so? (this is the oppposite of the Getting Started section)