triniwiz / nativescript-downloader

Apache License 2.0
32 stars 18 forks source link

Out of date dependency in Podfile that uses UIWebview #51

Open Gummby opened 4 years ago

Gummby commented 4 years ago

Hi there,

Sorry if this is a duplicate or known issue.

Apple is deprecating UIWebview, the Podfile dependency AFNetworking is version 3.0. They have removed the UIWebiview in version 4.0. Are you able to update this dependency as Apple will reject all iOS apps with UIWebview in them in September.

Thank you

Tom

triniwiz commented 4 years ago

Understood will try to get a release in

Gummby commented 4 years ago

Legend thank you

aaayushsingh commented 4 years ago

There is a commit but I don't see a new version published to npm yet. Is this resolved? I cannot submit my app to App Store anymore because of this

EDIT: It works by just changing the version from node modules. please publish to npm if other tests are passing too @triniwiz

ray007 commented 4 years ago

I just tried to upload a new build to the apple app store, and apple was not happy. Now anything using UIWebView gets rejected. This makes a new release here somewhat more urgent...

aaayushsingh commented 4 years ago

@ray007 if you need to urgently publish, go to node_modules/nativescript-downloader/platforms/ios/podfile and change the version of AFNetworking to 4.0.

It should look like pod 'AFNetworking', '~> 4.0' after you've changed it. You will need to make this change each time you reinstall node_modules.

After this build and publish and it should get accepted.

If you get a missing pod error, do pod repo update in a terminal window

ray007 commented 4 years ago

@aaayushsingh I already did that, thank you. But I really dislike editing in the node_modules folder...

Gummby commented 4 years ago

@ray007 a quick and dirty solution is to track the podfile with the change to 4.0. Slightly less gross than messing with node_modules. Slightly...

triniwiz commented 4 years ago

Updates coming soon

silviosan commented 3 years ago

Hi, are there any news regarding the update? It would really be great to have a new npm Version!

triniwiz commented 3 years ago

I'll try publishing this fix later today but all new work will be for v7+ (currently in progress)

silviosan commented 3 years ago

Thank you very much for your fast response and the good news!

jacopo69 commented 3 years ago

Thank you @triniwiz for your commitment