triniwiz / nativescript-pager

Apache License 2.0
90 stars 48 forks source link

fix pager height animation #173

Closed farfromrefug closed 4 years ago

farfromrefug commented 4 years ago

To make sure it works well during animations we need to make sure the pager width/height always match the holder native view

Without the fix May-14-2020 16-57-40

With the fix May-14-2020 16-57-50

felixkrautschuk commented 4 years ago

@triniwiz do you see any chance to publish this soon? This finally fixes https://github.com/triniwiz/nativescript-pager/issues/138 on Android (because there are special cases where the provided workarounds from that thread won't work).

felixkrautschuk commented 4 years ago

@triniwiz ?

triniwiz commented 4 years ago

@felixkrautschuk I'll try to get it out today 😄

felixkrautschuk commented 4 years ago

thanks, that would be awesome! 😄

felixkrautschuk commented 4 years ago

@triniwiz any updates? 😄 I really don't want to annoy you, but it would be great to know at least when this will go live.

felixkrautschuk commented 4 years ago

@triniwiz are there now any updates when this will go live?

farfromrefug commented 4 years ago

If you are using N rc version (N7.0) it has been released under @nativescript-community/ui-pager

felixkrautschuk commented 4 years ago

Don't understand why this important fix had to be published only for the NS 7 release candidate, but thank you for the feedback anyway @farfromrefug !

farfromrefug commented 4 years ago

@felixkrautschuk this is not what i am saying! And i totally agree with you that it has to be released for 6.x. I was just letting you know in case you needed for 7.x ;)

triniwiz commented 4 years ago

@felixkrautschuk it's published now

felixkrautschuk commented 4 years ago

@triniwiz thank you so much!!