triniwiz / nativescript-plugins

Apache License 2.0
80 stars 50 forks source link

[ffmpeg] incompatible `ffmpeg-kit-ios-full-gpl` version can be installed #107

Closed gelzis closed 1 year ago

gelzis commented 2 years ago

Hi.

Latest versions of ffmpeg-kit-ios-full-gpl break the plugin (current Pod requirement allows it), this commit renames the functions used by the plugin and when installing 4.5.1 it breaks. withExecuteCallback => withCompleteCallback

I guess its needed to either make version requirement stricter that this new version doesn't get installed or release new version of the plugin that supports the newest dependency and renames the function usage.

Workaround for this currently is to pin pod 'ffmpeg-kit-ios-full-gpl', '4.4.LTS' into project own Podfile, it duplicates the plugin declaration, but installs the 4.4 version and plugin is usable.

triniwiz commented 1 year ago

fixed on the latest release