triniwiz / nativescript-plugins

Apache License 2.0
80 stars 50 forks source link

Imagezoom build issue #109

Closed olsoluk closed 2 years ago

olsoluk commented 2 years ago

In include.gradle of ImageZoom package, the PhotoView version does not seem to exist which is causing a build error in my project.

com.github.chrisbanes:PhotoView:565505d5c

Can this be updated, or is there a workaround?

OPADA-Eng commented 2 years ago

Same here I managed to work around it by setting this in include.gradle file:

dependencies {
  implementation 'com.github.chrisbanes:PhotoView:2.3.0' // change here 
  implementation 'com.squareup.okhttp3:okhttp:3.14.9'
  implementation 'com.github.bumptech.glide:okhttp3-integration:4.11.0'
  implementation 'jp.wasabeef:glide-transformations:4.1.0'
  implementation 'com.github.bumptech.glide:glide:4.11.0'
  annotationProcessor 'com.github.bumptech.glide:compiler:4.11.0'
  annotationProcessor 'androidx.annotation:annotation:1.1.0'
}
wuilmerj24 commented 2 years ago

Fails with version of jp.wasabeef:glide-transformations

A problem occurred configuring project ':app'. Could not find jp.wasabeef:glide-transformations:4.1.0. Required by: project :app

OPADA-Eng commented 2 years ago

can you please include these files:

OPADA-Eng commented 2 years ago

@NathanWalker Have you published a new version on npm?

NathanWalker commented 2 years ago

I’ll check this tonight and ping back.

NathanWalker commented 2 years ago

@OPADA-Eng Looks like @triniwiz will need to publish the patch - will check with him on Monday about broadening the npm publish abilities on these packages.

OPADA-Eng commented 2 years ago

Thanks @NathanWalker

NathanWalker commented 2 years ago

@OPADA-Eng 4.1.2 is published now with that fix.