search

triniwiz / nativescript-plugins

Apache License 2.0
80 stars 50 forks source link

chore: couchbase libs update to 3.0.0 #132

Closed CatchABus closed 1 year ago

CatchABus commented 2 years ago

This update is needed mainly for iOS as cocoapods since 3.0.0 include arm64 and can be run on simulator. See: https://github.com/triniwiz/nativescript-plugins/issues/106

I also tested 3.0.0 on android and there were no breaking changes.

Fixes #106

triniwiz commented 2 years ago

Can you generate the new typings please

CatchABus commented 2 years ago

@triniwiz I generated typings for both platforms using ns typings <platform> command (I didn't know any other way tbh).

I see there are numerous changes in android and few changes in iOS. Do you thing they need to be examined?

Also, there is something strange about typings generation.

Method between has the following format in obj-c: https://docs.couchbase.com/mobile/2.8.4/couchbase-lite-objc/Classes/CBLQueryExpression.html#/c:objc(cs)CBLQueryExpression(im)between:and:

However, both old and new typings generated this:

between(expression1: CBLQueryExpression): CBLQueryExpression;

Is this normal? I suspect it might be related to "between:and being undefined" bug.

triniwiz commented 2 years ago

Might as well be a bug, I wonder if it's due the name 🧐