search

triniwiz / nativescript-plugins

Apache License 2.0
80 stars 50 forks source link

Update react and yoga #145

Closed shirakaba closed 1 year ago

shirakaba commented 1 year ago

The changes look big, but that's mainly because Prettier never got run on apps/demo-react or nativescript-yogalayout/react. For that reason, I've isolated the Prettier changes to two separate commits.

@ammarahm-ed I can help out with rebasing your work onto this to prepare a PR if this PR gets merged before any of your work (and I would recommend merging this PR first as it feels like the git history would make more sense this way round).

ammarahm-ed commented 1 year ago

Makes sense. Basically I made changes to just one file, Text.tsx. Rest was just fixing type errors, which I hope you have handled here hopefully.