search

triniwiz / nativescript-plugins

Apache License 2.0
80 stars 50 forks source link

[IOS] Handle Application delegate internally #148

Closed kefahB closed 1 year ago

kefahB commented 1 year ago

Hi @triniwiz,

I add handling the Application delegate internally because I had a conflict between this plugin and nativescript-community/universal-links declaring a new delegate for Stripe return url causing the loose of the data for the univseral-link plugin, there was a work around to set the universal link from the new app delegate but I saw that will be useful as we don't need to handling the return url on the app side anymore and creating a delegation. Also this will be better approach to prevent conflict with other plugins.

PS: This solution is done by nativescript-community

kefahB commented 1 year ago

Hi @triniwiz, what you think about this ?

NathanWalker commented 1 year ago

@kefahB we probably just need to check this against projects that also include Firebase. I think we have a sample app on firebase repo of such and could test these changes there.

kefahB commented 1 year ago

@NathanWalker Yes of course, I have modified this in my preproduction projet that we are in testing now, it seems work but yeah please do check it.

kefahB commented 1 year ago

@NathanWalker the last 2 commit concerne the plugin star-rating, I’ve added some extra feature for IOS like star size, unfortunately for android it is more complicated

kefahB commented 1 year ago

@triniwiz do you intent to push a new vision soon ?

triniwiz commented 1 year ago

Yes, cleaning up a few things first