triniwiz / nativescript-plugins

Apache License 2.0
78 stars 50 forks source link

[socket.io feature] Add auth payload for Android + fix extraHeaders #196

Closed bebrasmell closed 4 months ago

bebrasmell commented 4 months ago

About "extraHeaders": emptyMap is immutable, so when headers.put(key, value) is called, Java throws java.lang.UnsupportedOperationException. Consider using HashMaps instead.

About "auth_payload": This is a symmetric feature for my recent iOS Handshake payload PR. It works similar, but utilises Socket options builder's setAuth instead.

bebrasmell commented 4 months ago

I would appreciate pushing Auth payload feature for both iOS and Android to NPM once all the necessary checks are done.

triniwiz commented 4 months ago

Thank you @bebrasmell published in 5.0.3

bebrasmell commented 4 months ago

Thanks for keeping NS alive!