feat: ability to remove a single handler - Githubissues

triniwiz / nativescript-socketio

Socket.IO for nativescript

Apache License 2.0

71 stars 31 forks source link

feat: ability to remove a single handler #80

Closed gogoout closed 5 years ago

gogoout commented 5 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

the on(event,handler) return void

What is the new behavior?

the on(event,handler) now returns a function to remove the single handler.

gogoout commented 5 years ago

Hi @triniwiz , thanks for the merge. Do we have a ETA of the releasing?