search

triniwiz / nativescript-stripe

Apache License 2.0
49 stars 32 forks source link

feat(source): add support for creating stripe Sources #106

Closed MohammedBashiru closed 4 years ago

MohammedBashiru commented 4 years ago

What is the current behavior?

There is no support for creating stripe Sources. reference https://stripe.com/docs/mobile/ios/sources

What is the new behavior?

Added support for creating stripe Sources for iOS and Android reference https://stripe.com/docs/mobile/ios/sources https://stripe.com/docs/mobile/android/sources

Fixes/Implements/Closes #[Issue Number]. https://github.com/triniwiz/nativescript-stripe/issues/105

MohammedBashiru commented 4 years ago

We need to expose this in the Angular demo, as well. I can do that for you once everything is ready if you'd like.

Yes you can do that. Am not familiar with Angular

Finally, once we're ready to submit, the package version will need to be incremented (probably to 6.4.0 since new functionality was added) and the CHANGELOG updated.

Sure I'd leave that to you as well.

triniwiz commented 4 years ago

Atm it looks like you are only creating a card source also there are other source types you are allowed to create It would be nice to have all options available IOS : - https://stripe.dev/stripe-ios/docs/Classes/STPSourceParams.html Android :- https://stripe.dev/stripe-android/com/stripe/android/model/SourceParams.html

RobertGardner commented 4 years ago

@triniwiz Yes, we should support all the source types, especially Google Pay and Apple Pay. I'd like to get this submitted first with card support, and then add support for the other types in subsequent PRs. I can do some of that work, as well.