triniwiz / nativescript-stripe

Apache License 2.0
49 stars 34 forks source link

Add Nativescript 6.8.0 & Angular 10 support #125

Closed funder7 closed 3 years ago

funder7 commented 4 years ago

Recently the {N} team has introduced some very interesting updates in all their packages: Angular 10 (with Ivy compiler!) is now supported, and Angular 11 support is in the todo list. In order to be compatible with this updates, a plugin must be refactored by following some instructions, that will be released soon in a blog post on Nativescript website.

I was already working on other plugin updates in order to make them compatible with the latest {N} packages, since I was already in the plugin-update thing, and I needed to integrate Stripe payments in a personal project, I tried to update this plugin too. Thanks to Nathan Walker for having shared the changes needed to make the plugin compatible with ngcc.

Unfortunately I own an Android phone, and so build/test on iOS is not possible for me. Any contribution about this would be highly appreciated (@triniwiz ?)

Since the last release of the plugin, Stripe updated the SDKs:

I suggest to keep the SDK version as is for the moment, in order to check that this update has not introduced any new problem, then with the help of Chronos, we will think about this too :)

Just let me complete the last checks, then I'll submit the PR.

Cheers, Federico

triniwiz commented 4 years ago

I think Nathan has code for this will confirm first

ChadStrat commented 4 years ago

+1 any progress on this?

funder7 commented 4 years ago

HI @ChadStrat please check the discussion here #126 .. In the last days the stable version of nativescript has been released, so instead of releasing an update of nativescript-stripe with a release candidate it's better to use that. A user reported problems on iOS, I did some corrections that hopefully fixed that problems. I will try to finish the update this weekend, stay tuned.

triniwiz commented 3 years ago

Please update to {N} v7 then you can try https://github.com/triniwiz/nativescript-plugins