Like promised, I did some changes for the VideoRecorder, working like a charm on Android all versions, and on iOS. I didn't touched the AdvancedVideoRecorder, but it's my next step.
Changes I made are retro-compatibles, except for one, I moved requestPermissions inside the class.
I improved a little bit the structure, by using a common file.
I also improved error reporting and fixed some issues with the promises (when requiring permissions, mainly).
I fixed:
Issue #41 due to the use of API incorrectly
Issue #38
Hopefuly #21 but I can't reproduce
I also added those features:
choosing starting camera position on iOS & Android (front, back or none)
an isAvailable() method to check if device has camera support
I improved a bit the README and did a few other minor fixes and changes, no big deal.
Please review! (I know it's a big one, but didn't had time to do small batches)
Here are changes from commits:
fix: optional uses-feature camera & camera autofocus
fix: android recording on Marshmallow+ (#41, #21)
chore: typings for options
refactor: refactor android file + better handling of errors and permi…
refactor: better handle of default options
refactor: use a common file to keep common logic in one place
doc: update README
feat: add VideoRecorder::isAvailable() method, and deprecate options …
feat: add options.position = 'front' | 'back' | 'none'
fix: path of camera roll is now returned on ios (#38)
Hey !
Like promised, I did some changes for the
VideoRecorder
, working like a charm on Android all versions, and on iOS. I didn't touched theAdvancedVideoRecorder
, but it's my next step.Changes I made are retro-compatibles, except for one, I moved
requestPermissions
inside the class. I improved a little bit the structure, by using acommon
file.I also improved error reporting and fixed some issues with the promises (when requiring permissions, mainly).
I fixed:
I also added those features:
isAvailable()
method to check if device has camera supportI improved a bit the README and did a few other minor fixes and changes, no big deal.
Please review! (I know it's a big one, but didn't had time to do small batches)
Here are changes from commits: