trinker / pacman

A package management tools for R
314 stars 37 forks source link

Fix warning in `p_install_gh` when installing multiple packages #122

Open LoHertel opened 5 years ago

LoHertel commented 5 years ago

This PR addresses the warning message mentioned in #118 when installing multiple packages with p_install_gh().

The code in R/p_install_gh.R#L24 throws a warning message when passing a vector of repository names to the package argument: p_install_gh(c('path/package', 'path2/repo'))

Warning message:
if (p_loaded(char = package)):
  the condition has length > 1 and only the first element will be used

I propose the following changes:

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 44ceb33d9b7c9746f168789022f7b014bfc1a99f on LoHertel:fix-install-gh into fc09ccd2405e539dec575dbdf7832df82082d4e0 on trinker:master.