search

trinker / termco

Regular Expression Counts of Terms and Substrings
Other
25 stars 5 forks source link

Fix broken textstat_collocations calls #68

Closed kbenoit closed 6 years ago

kbenoit commented 6 years ago

Fixes the issue raised in https://github.com/trinker/termco/issues/41#issuecomment-362268808 where the use of remove_punct, remove_symbols cause warnings. These were never options to textstat_collocations(), but previously the ellipsis allowed these to be absorbed in the function call without a warning. In https://github.com/trinker/termco/blob/master/R/frequent_ngrams.R#L186 you have already removed them, so there is no need to remove them again.

In running the checks I also received a warning that your data objects could be reduced in size by recompressing them, so I've done that here too.

Finally I changed the quanteda version requirement to v1.0.0.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.004%) to 12.564% when pulling 18591e3cd0e0864c74a0596ef852807de6a7e56c on kbenoit:master into c5b52668a9c99685440fcfa2a2da8612d1eaddb2 on trinker:master.

trinker commented 6 years ago

@kbenoit thank you kindly for the PR. Much appreciated. And congrats on the latest quanteda release!