trinodb / aws-proxy

Proxy for S3
Apache License 2.0
7 stars 3 forks source link

Added file based credentials provider plugin #111

Closed pranavr12 closed 1 month ago

pranavr12 commented 1 month ago

The plugin enables file based credentials provider. This plugin is useful in doing quick POCs and can be used in docker compose workflow as well.

Usecase: The S3 proxy needs to know the mapped remote credentials for the emulated access key. Ideally, this would be a service that would be returning the remote credentials. However as a quick workaround, the same can be achieved by listing the credentials in a file and building a small a service to read and serve the remote credentials. This service does exactly the same

Tech details: The proposed approach is to implement this feature as a module, where the module reads the configurations from the properties file. If the required properties are loaded, then this credentialsProvider would be the sole implementation of CredentialsProvider interface.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Pranav Ramachandra. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Randgalt commented 1 month ago

This doesn't need to be a separate module. Please make this a package in the main module.

Randgalt commented 1 month ago

This plugin is useful in doing quick POCs

If this is merely meant for testing, etc. please add it to the test directory of the main module.

Randgalt commented 1 month ago

I don't think this needs to be written as a plugin. If someone wants to use it they can bind to it.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Randgalt commented 1 month ago

Thank you for all the changes. I'm looking into your CLA...

Please squash all the commits.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

pranavr12 commented 1 month ago

Thank you for all the changes. I'm looking into your CLA...

Please squash all the commits.

I've squashed the commits. We could as well enable 'Squash and Merge' option in settings

Randgalt commented 1 month ago

Thank you for all the changes. I'm looking into your CLA... Please squash all the commits.

I've squashed the commits. We could as well enable 'Squash and Merge' option in settings

We do rebase-merges

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla