search

trinodb / aws-proxy

Proxy for S3
Apache License 2.0
7 stars 3 forks source link

Remote S3 configs #116

Closed pranavr12 closed 1 month ago

pranavr12 commented 1 month ago

The remote s3 parameters can now be made configurable. Two types of styles can be used for referencing the s3 - PathStyle and VirtualHostStyle. The default hostname template for pathStyle is: "s3.${region}.${domain}" The default hostname template for virtualHostStyle is: "${bucket}.s3.${region}.${domain}"

The motivation behind this configuration: It may not always be the case where the region is always specified in the S3 URI (https://s3.testDomain.com) or the "s3" constant always remains "s3". The configuration can handle custom URIs such as: https://s3a.testDomain.com/ https://s3a.testDomain.us-east.com/ https://s3a.us-east.testDomain.com/

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

mosiac1 commented 1 month ago

Test failures are unrelated, see https://github.com/trinodb/aws-proxy/pull/115