search

trinodb / aws-proxy

Proxy for S3
Apache License 2.0
7 stars 3 forks source link

Bind IdentityType at top-level #138

Closed Randgalt closed 3 weeks ago

Randgalt commented 1 month ago 
          Since we are mapping abstract types, it is not possible to have the jsonCodecBinder registered in the module. However, once the abstract type has been mapped at a higher level, we could register the jsonCodecBinder. I'll address that in a separate PR since this change affects the FileBasedCredentialsProvider as well.

_Originally posted by @pranavr12 in https://github.com/trinodb/aws-proxy/pull/136#discussion_r1705338358_

vagaerg commented 4 weeks ago

I believe this was addressed by #145 , could we close this?

pranavr12 commented 3 weeks ago

Fixed through https://github.com/trinodb/aws-proxy/pull/141. Closing this issue