search

trinodb / aws-proxy

Proxy for S3
Apache License 2.0
7 stars 3 forks source link

Support max bytes quota for requests #96

Closed Randgalt closed 1 month ago

Randgalt commented 2 months ago

aws.proxy.request.quota.byte-qty

Closes #95

Randgalt commented 1 month ago

Throwing out an idea: we may be able to look at the Content-Length header (if the input/output aren't using Chunked Transfer-Encoding) and compare that to the quota

I think it's safer to use the bytes actually read. The purpose of this change is to make sure the proxy doesn't get DDOSd

mosiac1 commented 1 month ago

Regarding the naming, I do still think quota is not quite right. WDYT of max-payload-size?