search

trinodb / charts

Apache License 2.0
151 stars 174 forks source link

Template the password secret name #109

Closed huw0 closed 5 months ago

huw0 commented 1 year ago

As title

nineinchnick commented 6 months ago

@huw0 can you rebase?

huw0 commented 6 months ago

@nineinchnick - now rebased. With the changes I made in #108 it made sense for the helper to also be renamed in this PR.

I've tested with the following options which I think correctly preserve backwards compatibility. However it'd be worth confirming my assumptions :).

The default name of the secret is now - chartName-file-authentication. With .Values.auth.passwordAuthSecret set the behaviour is preserved and the secret is named to the passwordAuthSecret. With .Values.nameOverride set the secret is now chartName-nameOverride-file-authentication