Support namespace specification

trinodb / charts

Apache License 2.0

151 stars 174 forks source link

Support namespace specification #115

Closed LittleWat closed 8 months ago

LittleWat commented 11 months ago

This PR attempts to close #114

This would be the standard way to support namespace specification.

LittleWat commented 10 months ago

@hashhar sorry to ask you but could you kindly review this, please...? 🙏

mosabua commented 8 months ago

This looks good to me. It would be good if we can document this as part of the frigate generated doc or maybe in a separate markdown file in a docs folder or so. Over time I want to get more docs in that folder and into a site

mosabua commented 8 months ago

Also maybe @radek-starburst @nineinchnick or @losipiuk can chime in.

And @LittleWat I very much assume you tested and verified this already.

LittleWat commented 8 months ago

@mosabua thank you for your review!

And @LittleWat I very much assume you tested and verified this already.

Yes, I've tested this on my Linux ec2 machine. It worked as expected.

Looks good but we need to do some minimal docs.

Updated the README.md on how to use the helm template command by specifying the namespace!

Could you review this again, please...? 🙏

mosabua commented 8 months ago

Please rebase

LittleWat commented 8 months ago

@mosabua rebased!

mosabua commented 8 months ago

I think this is fine as long as we can get confirmation that this works transparently as before if no namespace parameter is passed in. I am not sure it does ...

LittleWat commented 8 months ago

I think this is fine as long as we can get confirmation that this works transparently as before if no namespace parameter is passed in. I am not sure it does ...

Thank you for your comment! if no namespace parameter is passed in, the namespace is set to default regardless of whether to include this difference or not. so it would be okay.