search

trinodb / charts

Apache License 2.0
144 stars 168 forks source link

Support service annotations #134

Closed p5 closed 4 months ago

p5 commented 7 months ago

Enables the user to add annotations for the service resource so it can be integrated with load balancers and others.

This is a similar PR to https://github.com/trinodb/charts/pull/54 and aims to resolve the long-standing issue https://github.com/trinodb/trino/issues/13085, however as the PR hasn't had any progress in almost a year, trying to push through separately.

cla-bot[bot] commented 7 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

p5 commented 7 months ago

Submitted the CLA. Waiting for someone to check it

p5 commented 7 months ago

@cla-bot check

cla-bot[bot] commented 7 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 7 months ago

The cla-bot has been summoned, and re-checked this pull request!

p5 commented 6 months ago

@cla-bot check

cla-bot[bot] commented 6 months ago

The cla-bot has been summoned, and re-checked this pull request!

ArnArm commented 5 months ago

Would be awesome to have this merged

nineinchnick commented 4 months ago

@p5 please rebase, and I'll review once the new tests pass in the CI.