search

trinodb / charts

Apache License 2.0
144 stars 168 forks source link

Add support to jmx metrics #140

Closed heitorrbarros closed 3 months ago

heitorrbarros commented 6 months ago

Hi!

I'm adding support to jmx metrics. It's usefull for capture metrics and build some monitoring system.

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 6 months ago

@cla-bot check

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 6 months ago

@cla-bot check

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 6 months ago

@cla-bot check

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 5 months ago

@cla-bot check

cla-bot[bot] commented 5 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 5 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 5 months ago

@cla-bot check

cla-bot[bot] commented 5 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 5 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 5 months ago

@cla-bot check

cla-bot[bot] commented 5 months ago

The cla-bot has been summoned, and re-checked this pull request!

nineinchnick commented 4 months ago

@heitorrbarros please rebase and add a test, similar to https://github.com/trinodb/charts/blob/main/charts/trino/templates/tests/test-connection.yaml, that would check if the JMX metrics can be queried, when enabled. Enable them in https://github.com/trinodb/charts/blob/main/test-values.yaml