trinodb / charts

Apache License 2.0
144 stars 168 forks source link

Setting `additionalLogProperties` gives error #141

Closed xiaoPierre closed 6 months ago

xiaoPierre commented 6 months ago

Hello,

I was trying to set some logging properties with additionalLogProperties field, with something like

additionalLogProperties:
  - "log.path=var/log/server.log"

However I got an error java.lang.IllegalArgumentException: No enum constant io.airlift.log.Level./VAR/LOG/SERVER.LOG

After some trials, I found out that the logging properties may need to be set in config.properties instead of log.properties, which is supposed to contain only log level.

Would someone be able to valid that it's a valid issue, and confirm whether the similar issue exists for other additional* variables in the chart ? Thanks in advance.

mosabua commented 6 months ago

Log properties should be set in log.properties file .. which is what the chart does. The additionalLogProperties should be single log lines for that file in the format package=loglevel:

Try something like this:

additionalLogProperties:

The linked logging properties are for configuring logging .. not for setting log levels. It might be a bit badly named, if you want to use those they go into config.properties file so in additionalConfigProperties

xiaoPierre commented 6 months ago

Thanks for the explanation ! Closing the issue