trinodb / charts

Apache License 2.0
133 stars 149 forks source link

feat: Add fsGroup option into securityContext #151

Open heitorrbarros opened 2 months ago

heitorrbarros commented 2 months ago

Related issue

cla-bot[bot] commented 2 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

heitorrbarros commented 2 months ago

@cla-bot check

cla-bot[bot] commented 2 months ago

The cla-bot has been summoned, and re-checked this pull request!

heitorrbarros commented 1 month ago

Hi @nineinchnick, could you please help me review my PR?

nineinchnick commented 1 month ago

@heitorrbarros I recently added a more complete test in https://github.com/trinodb/charts/blob/main/test-values.yaml. Would you like to configure the cache usage in there so we can make sure that this change actually makes the volume writable?