trinodb / charts

Apache License 2.0
151 stars 174 forks source link

additional volume and volume mount is not working #152

Closed bhargav2427 closed 3 months ago

bhargav2427 commented 7 months ago

I checked and additionalVolumes and additionalVolumeMounts option of coordinator and worker is not working. After these changes, I can see the volumes and volumeMounts in helm template.

cla-bot[bot] commented 7 months ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bhargav Akhani. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
bhargav2427 commented 7 months ago

Hi @losipiuk @mosabua Please take a look.

losipiuk commented 7 months ago

When I put this in values:

  additionalVolumes:
     - name: extras
       emptyDir: {}
     - name: extras2
       emptyDir: {}

  additionalVolumeMounts:
     - name: extras
       mountPath: /usr/share/extras
       readOnly: true
     - name: extras2
       mountPath: /usr/share/extras2
       readOnly: true

and render template I get

      volumes:
        ....
        - emptyDir: {}
          name: extras
        - emptyDir: {}
          name: extras2
.....
          volumeMounts:
        ....
            - mountPath: /usr/share/extras
              name: extras
              readOnly: true
            - mountPath: /usr/share/extras2
              name: extras2
              readOnly: true

seems fine to me

bhargav2427 commented 7 months ago

@losipiuk Can we please merge it? So, I can use this in my production.

bhargav2427 commented 6 months ago

@LittleWat @huw0 @florianMalbranque @ryan0x44 Please take a look.

huw0 commented 6 months ago

@bhargav2427 I'm using the 0.19.0 chart successfully with both ConfigMap and PVC mounts.

What version of helm are you using? Are you able to share an example config that exhibits the issue?

nineinchnick commented 3 months ago

I'm closing it since it's abandoned.