search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Enabled overrides for worker and coordinator configmap resources #163

Closed silent-lad closed 5 months ago

silent-lad commented 6 months ago

This is to install multiple helm releases of trino cluster in the same namespace. Closes #159 .

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 6 months ago

Would be nice to have a test for this, maybe a second call to ct install in https://github.com/trinodb/charts/blob/main/.github/workflows/ci-cd.yaml#L44

nineinchnick commented 6 months ago

@silent-lad I recently added a test.sh script that runs multiple tests. Can you update it to add a new test for deploying multiple releases into a single namespace? If you'd use ct install, you'd have to disable cleanup when calling it. test.sh already creates and cleans up a custom namespace.

silent-lad commented 6 months ago

Hey @nineinchnick , will do the same. Thanks for the heads up

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

silent-lad commented 6 months ago

@silent-lad I recently added a test.sh script that runs multiple tests. Can you update it to add a new test for deploying multiple releases into a single namespace? If you'd use ct install, you'd have to disable cleanup when calling it. test.sh already creates and cleans up a custom namespace.

This is done now.

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 6 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

silent-lad commented 6 months ago

Have pushed the required changes @nineinchnick

nineinchnick commented 5 months ago

@cla-bot check

cla-bot[bot] commented 5 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 5 months ago

The cla-bot has been summoned, and re-checked this pull request!