search

trinodb / charts

Apache License 2.0
133 stars 149 forks source link

Sync JVM flags with Trino defaults #164

Closed nineinchnick closed 1 month ago

nineinchnick commented 1 month ago

As expected, older versions fail to run with:

Unrecognized VM option 'G1NumCollectionsKeepPinned=10000000'

I could add a condition on the image.tag, but when using custom-built images, it doesn't have to be a version number. It's not possible to specify a different app version when installing the chart, so we can't use this field.

Maybe we should consider removing the default JVM flags from the chart and rely on those in the image, unless explicitly set?

nineinchnick commented 1 month ago

I tried preparing another PR that would not override the default jvm.config but it's tricky, because we include values from the .Values.coordinator.jvm section. Handling this would require complex logic and IMO it's not worth it.