search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

feat: added ability to define the nodePort in the trino service #204

Closed dantonbertuol closed 3 months ago

dantonbertuol commented 3 months ago

Hello.

This PR is to be able to customize the NodePort in the Trino service.

I adjusted it due to the issue https://github.com/trinodb/charts/issues/203.

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 3 months ago

Please update the README - see the CI run failure: https://github.com/trinodb/charts/actions/runs/10386833434/job/28759113778?pr=204

Also, squash the commits into a single one. I can merge this as soon as the CLA clears out.

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

dantonbertuol commented 3 months ago

Please update the README - see the CI run failure: https://github.com/trinodb/charts/actions/runs/10386833434/job/28759113778?pr=204

Also, squash the commits into a single one. I can merge this as soon as the CLA clears out.

I changed it as per your request.

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

dantonbertuol commented 3 months ago

@nineinchnick This error is a little strange, don't you think? https://github.com/trinodb/charts/actions/runs/10387904546/job/28762488147?pr=204

nineinchnick commented 3 months ago

I copied those two lines into a text editor and only then noticed that there are two spaces missing at the end of the line. This is needed by markdown to correctly wrap the following lines into the bullet point.

I should have mentioned this earlier - you shouldn't edit the file manually, but use helm-docs to generate it automatically. There's a pre-commit hook that you could install to have this done automatically when you commit any other changes.

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

dantonbertuol commented 3 months ago

I copied those two lines into a text editor and only then noticed that there are two spaces missing at the end of the line. This is needed by markdown to correctly wrap the following lines into the bullet point.

I should have mentioned this earlier - you shouldn't edit the file manually, but use helm-docs to generate it automatically. There's a pre-commit hook that you could install to have this done automatically when you commit any other changes.

Ah, thanks for the information, I adjusted the readme again.

dantonbertuol commented 3 months ago

Hi @nineinchnick!

My CLA has been completed.

nineinchnick commented 3 months ago

@cla-bot check

cla-bot[bot] commented 3 months ago

The cla-bot has been summoned, and re-checked this pull request!