search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Support custom password auth properties file #218

Closed yardenc2003 closed 2 months ago

yardenc2003 commented 2 months ago

As for now, one you've set your auth type to "PASSWORD" via Values.server.config.authenticationType, you are forced to use a specific conf file set for password file auth.

This implementation restricts auth configurations in the following ways:

  1. It restricts the usage of configurations specific to that auth implementation (e.g., we cannot configure file.auth-token-cache.max-size).
  2. Even worse, it does not allow configuring LDAP properties, which should also be enabled by the "PASSWORD" auth type.

This PR suggests a small fix to address these scenarios.

cla-bot[bot] commented 2 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

yardenc2003 commented 2 months ago

@cla-bot check

cla-bot[bot] commented 2 months ago

The cla-bot has been summoned, and re-checked this pull request!